Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(useVirtual): do not trigger onScroll and loadMore by internally scroll-to method #154

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

wellyshen
Copy link
Owner

  • Fix(useVirtual): do not trigger onScroll and loadMore by internally scroll-to method

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2021

🦋 Changeset detected

Latest commit: abc5880

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-cool-virtual Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jun 19, 2021

Pull Request Test Coverage Report for Build 951974512

  • 7 of 13 (53.85%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.6%) to 51.54%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/useVirtual.ts 7 13 53.85%
Files with Coverage Reduction New Missed Lines %
src/useVirtual.ts 3 41.73%
Totals Coverage Status
Change from base Build 951815200: -2.6%
Covered Lines: 182
Relevant Lines: 284

💛 - Coveralls

@github-actions
Copy link
Contributor

Size Change: +192 B (+1%)

Total Size: 21.2 kB

Filename Size Change
dist/index.cjs.development.js 4.93 kB +45 B (+1%)
dist/index.cjs.production.min.js 3.03 kB +28 B (+1%)
dist/index.esm.js 4.87 kB +44 B (+1%)
dist/index.umd.development.js 5.1 kB +45 B (+1%)
dist/index.umd.production.min.js 3.11 kB +30 B (+1%)
ℹ️ View Unchanged
Filename Size Change
dist/index.js 136 B 0 B

compressed-size-action

@wellyshen wellyshen merged commit 0eeae8f into master Jun 19, 2021
@wellyshen wellyshen deleted the fix/on-scroll-events branch June 19, 2021 06:48
@github-actions github-actions bot mentioned this pull request Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants