Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf (useVirtual): mutate inner element styles only when items are updated #173

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

wellyshen
Copy link
Owner

  • perf (useVirtual): mutate inner element styles only when items are updated

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2021

🦋 Changeset detected

Latest commit: 70d04ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-cool-virtual Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Size Change: -9 B (0%)

Total Size: 21 kB

Filename Size Change
dist/index.cjs.development.js 4.9 kB +1 B (0%)
dist/index.cjs.production.min.js 2.99 kB -6 B (0%)
dist/index.umd.development.js 5.07 kB -1 B (0%)
dist/index.umd.production.min.js 3.08 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
dist/index.esm.js 4.84 kB
dist/index.js 136 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jul 4, 2021

Pull Request Test Coverage Report for Build 998451862

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.43%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/useVirtual.ts 9 11 81.82%
Totals Coverage Status
Change from base Build 996865897: 0.1%
Covered Lines: 265
Relevant Lines: 283

💛 - Coveralls

@wellyshen wellyshen merged commit c7f377e into master Jul 4, 2021
@wellyshen wellyshen deleted the refactor-inner-mutations branch July 4, 2021 13:32
This was referenced Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants