Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong the scroll position of scrollToItem when working with dynamic size #95

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

wellyshen
Copy link
Owner

  • fix: wrong the scroll position of scrollToItem when working with dynamic size

@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2021

🦋 Changeset detected

Latest commit: ddc2846

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-cool-virtual Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2021

Size Change: -343 B (-2%)

Total Size: 19.2 kB

Filename Size Change
dist/index.cjs.development.js 4.48 kB -92 B (-2%)
dist/index.cjs.production.min.js 2.74 kB -38 B (-1%)
dist/index.esm.js 4.42 kB -89 B (-2%)
dist/index.umd.development.js 4.64 kB -91 B (-2%)
dist/index.umd.production.min.js 2.83 kB -33 B (-1%)
ℹ️ View Unchanged
Filename Size Change
dist/index.js 136 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jun 3, 2021

Pull Request Test Coverage Report for Build 903441152

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 2.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/useVirtual.ts 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/useVirtual.ts 2 0%
Totals Coverage Status
Change from base Build 903203495: 0.07%
Covered Lines: 7
Relevant Lines: 256

💛 - Coveralls

@wellyshen wellyshen merged commit 8dd7313 into master Jun 3, 2021
@wellyshen wellyshen deleted the fix/scroll-to-item branch June 3, 2021 15:55
@github-actions github-actions bot mentioned this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants