Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience dates - display as years #22

Merged

Conversation

NetworkMonk
Copy link
Contributor

I've added a small customisation option that you can set in the json_stub.json file

{
    ...
    "customization": {
        ...
        "work": {
            "displayDatesAsYears": false
        }
    }
}

The default is false, but you can set to true if you only want to display the dates as years on the work / experiences card. (When your work experiences are over long periods of time).

@clementdevos
Copy link
Collaborator

clementdevos commented Mar 30, 2020

Hey, i've slightly modified your PR so that we

  • use the customization object, not the passed data to the resume (the customization object in the resume should not be used, i'll make sure of that later)
  • change the boolean to a plain string moment format , this is more flexible
  • add this to the doc.

What do you think?

@NetworkMonk
Copy link
Contributor Author

Yeah that makes more sense, use a custom date format, looks really good, thanks.

Copy link
Collaborator

@clementdevos clementdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after changing it to dateformat

@clementdevos clementdevos changed the base branch from master to develop March 31, 2020 09:53
@clementdevos clementdevos merged commit 3794ab4 into welovedevs:develop Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants