Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: unify and rephrase options descriptions #12

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Feb 7, 2024

Summary

Unifies --help and default config strings.

Now there's one source of truth for these strings, which will become handy for the next PR ✌️


How has this been tested?

  • Manual tests
  • Unit tests
  • Integration tests

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have read the contributing guidelines.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I have formatted the code with cargo fmt.
  • My change requires updating the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8eca1e3) 95.81% compared to head (b2ac378) 95.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   95.81%   95.83%   +0.01%     
==========================================
  Files          10       10              
  Lines         622      624       +2     
==========================================
+ Hits          596      598       +2     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@welpo welpo merged commit 85078f0 into main Feb 8, 2024
14 checks passed
@welpo welpo deleted the refactor/unify-options branch February 8, 2024 00:06
welpo added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants