Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add battery actuator temperature #352

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Add battery actuator temperature #352

merged 2 commits into from
Jan 20, 2024

Conversation

gorge511
Copy link
Contributor

Hi @weltenwort I consider this entity useful. I use it together with the heat sink temp for controlling our external fan. So I wanted to be available also for others.

@weltenwort
Copy link
Owner

weltenwort commented Jan 20, 2024 •
edited
Loading

Edit: my fault, I read this as a request 🙈 thanks for submitting this!

Hi @gorge511, could you clarify which temperature measurement that is? Is it different from the battery_temperature that is already exposed?

@weltenwort weltenwort added the enhancement New feature or request label Jan 20, 2024
weltenwort
weltenwort reviewed Jan 20, 2024
View reviewed changes
Copy link
Owner

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for submitting. Would you mind adding an entry to the entity table in the README?

custom_components/rct_power/lib/entities.py Show resolved Hide resolved
@gorge511
Copy link
Contributor Author

Would you mind adding an entry to the entity table in the README?

Sure, no problem. Added in 256f2d4

weltenwort
weltenwort approved these changes Jan 20, 2024
View reviewed changes
Copy link
Owner

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thank you. And special props for syncing the info.md content too.

@weltenwort weltenwort merged commit f4ffe3f into weltenwort:main Jan 20, 2024
5 checks passed
@gorge511 gorge511 deleted the bat_actuator branch January 20, 2024 23:45
@weltenwort
Copy link
Owner

ℹ️ released in https://github.com/weltenwort/home-assistant-rct-power-integration/releases/tag/v0.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gorge511 @weltenwort