Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of inspect.stack(), fix #532 #533

Merged
merged 1 commit into from Apr 5, 2024

Conversation

bckohan
Copy link
Contributor

@bckohan bckohan commented Apr 5, 2024

As mentioned in #532 inspect.stack() builds frame information for the entire stack which is unnecessarily slow.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this code is very old :)

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (654b1a6) to head (5fbb386).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #533   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           41        42    +1     
  Branches         7         7           
=========================================
+ Hits            41        42    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sobolevn sobolevn merged commit 7928e18 into wemake-services:master Apr 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants