Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an option to make MRs only for insecure deps #29

Open
lorvent opened this issue May 29, 2019 · 9 comments
Open

an option to make MRs only for insecure deps #29

lorvent opened this issue May 29, 2019 · 9 comments

Comments

@lorvent
Copy link
Contributor

lorvent commented May 29, 2019

Hello,
dependabot says it can check for insecure deps.

is there anyway, we can do same here with kira?

we have a php/laravel application where we use old versions intentionally, it is making MRs for latest versions which could break application.

so i want to know, if there is any way to achieve what i want i.e. let bot create MRs only for security vulnerabilities.

thanks

@sobolevn
Copy link
Member

sobolevn commented May 29, 2019

Yes, dependabot can do it: wemake-services/wemake-django-template#749

Here's my idea:

  1. Use this method: https://github.com/dependabot/dependabot-core/blob/0549ebab2530b8287654da00ee382e72f4814c54/common/lib/dependabot/update_checkers/base.rb#L106
  2. Only allow to create MRs for security updates: next unless checker.vulnerable?
  3. Add an option DEPENDABOT_ONLY_SECURITY to make this configurable

Please, report if that works for you.

@lorvent
Copy link
Contributor Author

lorvent commented May 29, 2019

thanks for the tip.
unfortunately i have no idea of ruby, so i have to wait till someone makes a PR for it.
thanks.

@sobolevn
Copy link
Member

@lorvent ok, I will do it in ~7 days.

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2019

Still no solution from my side. Sorry. Any ideas?

@lorvent
Copy link
Contributor Author

lorvent commented Jun 7, 2019

are we checking for deps using dependabot api

or directly checking with packagist.org and nmpjs.com ?

depending on that...we should findout may be.

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2019

Nope, just dependabot. Other options are out of scope of this project.

@lorvent
Copy link
Contributor Author

lorvent commented Jun 7, 2019

but i can't find any api link for dependabot.

can you please provide link?

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2019

I am not quite familiar with dependabot's code base and ruby (in fact that's my first ruby project and I still do even red a tutorial), but here you go a search reference: https://github.com/dependabot/dependabot-core/search?q=security&unscoped_q=security

@lorvent
Copy link
Contributor Author

lorvent commented Jun 9, 2019

hmm, lets hope someone else will make a PR for it, since they already have option to filter by security update or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants