-
-
Notifications
You must be signed in to change notification settings - Fork 385
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Why? Because it is too complex and bring a very little value. Let me explain. Annotations can be used in multiple ways: 1. As Python structures: `List[int]` 2. As strings: `'SelfType[T]'` 3. As a mix of these two: `List['SelfType[T]']` It is also really hard to tell that annotations are really the same. Because, here's how one can write `Literal` (as an example): 1. `Literal[1]` 2. `typing.Literal[1]` 3. `t.Literal[1]` 4. `te.Literal[1]` 5. `typing_extensions.Literal[1]` 6. `'Literal[1]'` 7. ... It would be the same annotation in all these cases. But different `ast` nodes. Comparing them is hard. And error-prone. We also break one very important princible of our project: we assume types. That's why it is reverted.
- Loading branch information
Showing
16 changed files
with
5 additions
and
536 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,4 +68,3 @@ wemake-python-styleguide WPS, defined here | |
best_practices.rst | ||
refactoring.rst | ||
oop.rst | ||
annotations.rst |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 0 additions & 48 deletions
48
tests/test_visitors/test_ast/test_annotations/test_annotation_metadata/conftest.py
This file was deleted.
Oops, something went wrong.
151 changes: 0 additions & 151 deletions
151
tests/test_visitors/test_ast/test_annotations/test_annotation_metadata/test_flat_types.py
This file was deleted.
Oops, something went wrong.
58 changes: 0 additions & 58 deletions
58
tests/test_visitors/test_ast/test_annotations/test_annotation_metadata/test_literal_none.py
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.