False positive Z309 for keys closes #528 (#532)

wemake-services · Mar 29, 2019 · df14668 · df14668
1 parent a6a30b0
commit df14668
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,15 @@
 We follow Semantic Versions since the `0.1.0` release.
 We used to have incremental versioning before `0.1.0`.
 
+## 0.9.0
+
+### Features
+
+- Forbid to use multiline conditions
+
+### Bugfixes
+
+- Fixes problem with missing _allowed_left_nodes
 
 ## 0.8.1
 

diff --git a/tests/test_visitors/test_ast/test_comparisons/test_order.py b/tests/test_visitors/test_ast/test_comparisons/test_order.py
@@ -23,6 +23,7 @@
     ('first_name + second_name', 1),
     ('error.code', 'errors[index].code'),
     (1, 2),
+    ('returned_item["id"]', 'office.id'),
 ])
 def test_comparison_variables(
     assert_errors,

diff --git a/wemake_python_styleguide/visitors/ast/comparisons.py b/wemake_python_styleguide/visitors/ast/comparisons.py
@@ -79,6 +79,7 @@ class WrongComparisionOrderVisitor(BaseNodeVisitor):
         ast.Name,
         ast.Call,
         ast.Attribute,
+        ast.Subscript,
     )
 
     _special_cases: ClassVar[AnyNodes] = (