Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect message for WPS349 #1044

Closed
sobolevn opened this issue Dec 1, 2019 · 0 comments · Fixed by #1062
Closed

Incorrect message for WPS349 #1044

sobolevn opened this issue Dec 1, 2019 · 0 comments · Fixed by #1062
Labels
bug Something isn't working help wanted Extra attention is needed level:starter Good for newcomers pr-merged
Milestone
Version 0.13.x

Comments

@sobolevn
Copy link
Member

sobolevn commented Dec 1, 2019

Bug report

What's wrong

Code:

'eman'[None:None:-1]

Output:

  1:1      WPS349 Found redundant subscript slice: <_ast.Subscript object at 0x106f57e50>
  'eman'[None:None:-1]
  ^

How is that should be

It should be WPS349 Found redundant subscript slice
@sobolevn sobolevn added bug Something isn't working help wanted Extra attention is needed level:starter Good for newcomers labels Dec 1, 2019
@sobolevn sobolevn added this to the Version 0.13.x milestone Dec 1, 2019
andreaestrada added a commit to andreaestrada/wemake-python-styleguide that referenced this issue Dec 8, 2019
@andreaestrada
Fix error message for WPS349
b872a08 
Fix issue wemake-services#1044.
@andreaestrada andreaestrada mentioned this issue Dec 9, 2019
Merged
3 tasks
@helpr helpr bot added the pr-available label Dec 9, 2019
sobolevn pushed a commit that referenced this issue Dec 9, 2019
@andreaestrada @sobolevn
Update violation docs for yield from violation. (#1062)
a00d479 
* Update violation docs for yield from violation.

Address issue #1057. Update violation docs to make it easier for developers to understand how to refactor more complex yield statements.

* Fix error message for WPS349

Fix issue #1044.

* Update CHANGELOG.md

* Update refactoring.py
@helpr helpr bot added pr-merged and removed pr-available labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed level:starter Good for newcomers pr-merged
Projects
None yet
Milestone
Version 0.13.x
Development

Successfully merging a pull request may close this issue.

Update violation docs for yield from violation. andreaestrada/wemake-python-styleguide
1 participant
@sobolevn