Issue #506 #526
Merged
Issue #506 #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1162
💛 - Coveralls |
sobolevn
requested changes
Mar 27, 2019
|
|
||
| incorrect_or_conditions1 = """ | ||
| if some or ( | ||
| other==1 |
| other, | ||
| ): | ||
| ... | ||
| """ |
There was a problem hiding this comment.
Please, also include:
- Correct conditions with multiple
andandor - Correct conditions with
()like function calls, prioritisation, and tuples - Incorrect conditions for multiple lines: 2, 3 and 4
|
|
||
| error_template = 'Found nested `try` block' | ||
| code = 464 | ||
| # -*- coding: utf-8 -*- |
There was a problem hiding this comment.
This diff is incorrect, please fix it.
tests/test_checker/test_noqa.py
Outdated
|
|
||
| for violation in IGNORED_VIOLATIONS: | ||
| assert stdout.count(violation) > 0 | ||
| # -*- coding: utf-8 -*- |
There was a problem hiding this comment.
This diff is incorrect, please fix it.
tests/fixtures/noqa.py
Outdated
| raise TypeError('Second') | ||
| except TypeError: | ||
| print('WTF?') | ||
| # -*- coding: utf-8 -*- |
There was a problem hiding this comment.
This diff is incorrect, please fix it.
| Forbids to use magic numbers in your code. | ||
|
|
||
| What we call a "magic number"? Well, it is actually any number that | ||
| appears in your code ou |
| Forbids to use magic numbers in your code. | ||
|
|
||
| What we call a "magic number"? Well, it is actually any number that | ||
| appears in your code ou |
| self._check_negated_conditions(node) | ||
| self._check_redundant_else(node) | ||
| self.generic_visit(node) | ||
| # -*- coding: utf-8 -*- |
There was a problem hiding this comment.
This diff is incorrect, please fix it.
|
|
||
| def _check_multiline_conditions(self, node: ast.If) -> None: | ||
| """Checks multiline conditions ``if`` statement nodes.""" | ||
| if isinstance(node.test, ast.BoolOp): |
There was a problem hiding this comment.
In this case you are ignoring cases like:
if very_long_call_name(
long_parameter_name=long_variable_name,
):Please, make sure it is covered and tested.
There was a problem hiding this comment.
Change and tested it
sobolevn
requested changes
Mar 27, 2019
| @@ -378,3 +378,40 @@ def bad_default_values( # noqa: Z459 | |||
| raise TypeError('Second') | |||
| except TypeError: | |||
| print('WTF?') | |||
|
|
|||
| if some and ( # noqa: Z465 | |||
There was a problem hiding this comment.
There's no need in putting all of these cases inside noqa.py.
It only contains integration tests. One is enough.
Move other cases into unit tests.
tests/test_checker/test_noqa.py
Outdated
| @@ -151,6 +151,7 @@ def test_noqa_fixture_disabled(absolute_path, all_violations): | |||
| 'Z462': 1, | |||
| 'Z463': 1, | |||
| 'Z464': 1, | |||
| 'Z465': 5, | |||
| """ | ||
|
|
||
| correct_conditions3 = """ | ||
| if (some_func(k) and some) or other in (1,2,3): |
There was a problem hiding this comment.
Please, add:
correct_conditions4 = """
if one:
if two:
...
"""
sobolevn
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid multiline conditions, closes #506