-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for "1 / any number" expression #786
Add test for "1 / any number" expression #786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is! Thanks for asking!
I added ipdb to code and want to understand where code return error and where need fix function.
Because of the need to fix this problem - #775 |
Try |
ca4fe41
to
603cc5f
Compare
@pytest.mark.parametrize('expression', [ | ||
'1 / other', | ||
'1 / 11', | ||
'1 / 1.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, also check 1 / 1
. It should raise a violation because of the / 1
part
@serhii73 thanks! I will take it from here, since I am releasing |
You're welcome. |
See my fix: 9b3c155#diff-b9425bbc8c1b7baf877d6cbb75055e64R109 It was a |
Fix #775