Add acceptance test for WPS125 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vergeev gracias! Do you use this project in a real life development? I can even invite you to collaborate, since I don't have much time to work on this. |
|
I'm not using it for any production projects right now, but planning on doing so. I'm also one of the Fiasko Bro developers and I'm thinking of making Fiasko compatible with flake8 plugins. I think I want to contribute more before becoming a collaborator, thank you! |
sobolevn
added a commit
that referenced
this pull request
Oct 20, 2020
* feat: added the new violation to be completed, closes #7 * refac: refactor for flake8 consistancy, issue #7 * feat: implementing the new rule. Build yet to be debugged. Issue #9 * test: added a test for violation WPS357. A raw string must contain the '\' character. If there is no '\' in the string a raw string should not be used. Closes issue #8 Relates to issue#1081 on the original repository * documentation: Added documentation for the violation RawStringNotNeededViolation (WPS357). Follows the general structure for documentation. Relates to original issue #1081. Closes #11 * fix: Removed an unnecessary single quotation mark in the documentation relates to #11 * fix: repaired build a priori, issue #9 * fix: adapted test suite to respect the new rule. Temporarily removed some cases to make the test pass. Related to issue #9 * fix: corrected the WPS warnings, issue #9 * fix: enforce the new rule WPS357 in the project itself * refac: old tests to match the new rule or ignore it, issue #9 * refac: last refactoring. Closes #9 * doc: changelogs for new rule * test: added a test for wrong case. PR #1178 * fix: minor changes required for PR #1187 * Doc: * CHANGELOG.md: new header for release 0.15.0 * added contribution * Related to PR #1178 * test: new tests for rule WPS357. Not passing for escaped quote. PR #1178 * fix: correct type and missing newline. PR #1178 * tests: refactored tests that now all pass. Closes #9. Related to PR #1178 * doc: the previous usage was actually a wrong usage. PR #1178 * refac: remove useless encode().decode() * merged and solve the conflits. All tests pass * fix: minor changes for PR #1178 * fix: error linter wrong indentation, related to PR #1178 * fix: wrong error_template in for RawStringNotNeededViolation * Fixes Ci * Fixes Ci Co-authored-by: Mael MADON <mael.madon@polytechnique.edu> Co-authored-by: fabian.waldner@gmail.com <fabian.waldner@gmail.com> Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6