Feat : eth_getReceipts API #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wm-jsong1230
requested review from
cp-khs and
wm-jsong1230
and removed request for
wm-jsong1230
wmxcreator
reviewed
Nov 2, 2022
wmxcreator
reviewed
Nov 2, 2022
internal/web3ext/web3ext.go
Outdated
| @@ -611,6 +611,18 @@ web3._extend({ | |||
| params: 1, | |||
| inputFormatter: [web3._extend.formatters.inputTransactionFormatter] | |||
| }), | |||
| new web3._extend.Method({ | |||
| name: 'getReceipts', | |||
| call: 'wemix_getReceipts', | |||
There was a problem hiding this comment.
For clarity, I would recommend changing the method name "eth_getReceipts" to "eth_getReceiptsByBlockHash".
wmxcreator
suggested changes
Nov 2, 2022
|
Reflect feedback from @wmxcreator. Thank you. |
Wade-wemade
requested review from
wmxcreator
and removed request for
sadoci,
cp-khs and
wm-jsong1230
|
LGTM |
saddoc
pushed a commit
to saddoc/go-wemix
that referenced
this pull request
Jul 14, 2023
Metadium to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eth_getReceipts
With this api, you can get all transaction receipts of a block at once.
parameter : block hash
return : types.receipts