Make unsplit packages unless necessary #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Wed, Feb 21, 2024 at 07:54:05AM -0800, 尹良灿 wrote:
@hseg Could you help on testing this change by `Python2`? I just fixed two compatibility issues of your last PR .
f91604a
cad0293
OK, though you do know that Python 2 has been EOL for three years now, right?
Checking with `python2 pip2pkgbuild/pip2pkgbuild.py -o pip` on HEAD, am seeing
no errors, what codepaths do you still want me to test?
|
hseg
force-pushed
the
unsplit-default
branch
from
655fbbe
to
8076b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template currently makes split packages containing 1/2 packages, making the output needlessly complex.
Instead, only split if
--multis passed.Conceptually, this does not depend on #29, but I'd rather not have to rebase it on top if they're both accepted.