add rest call to archive course versions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dporru
suggested changes
Nov 3, 2016
| @@ -206,6 +206,10 @@ def set_course(self, course): | |||
| def delete_course(self, course_id): | |||
| return self._request('DELETE', 'course/{}/'.format(course_id)) | |||
|
|
|||
| def set_student_courseversion(self, action, course_id, student_id): | |||
There was a problem hiding this comment.
We use the spelling course_version throughout Pluvo.
|
I think right now, with archive as our only action it's definitely more intuitive from a user perspective to put the We might have to rethink this if we start adding a bunch more actions. I'm hesitant to have to make a different function for ~10 different actions. I'll rename it for now |
dporru
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need I say more?