Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeout设置无效 #12

Closed
sunsl516 opened this issue Aug 24, 2018 · 2 comments
Closed

timeout设置无效 #12

sunsl516 opened this issue Aug 24, 2018 · 2 comments

Comments

@sunsl516
Copy link

timeout属性设置后会被代理成timeout_属性，虽然有对timeout做get劫持，但是貌似xhr内部在处理超时的时候并没有取timeout_这个属性，而是仍然取得是timeout属性，导致属性失效，估计设置withCredential也会出现同样的问题。
@sunsl516
Copy link
Author

感觉问题很多啊

@wendux
Copy link
Owner

wendux commented Aug 24, 2018

38行这确实有问题，当初设置带下划线的属性是因为xhr有些属性是只读的不能赋值。这一块应该做一个属性过滤，只需要为只读属性生成代理属性，其它属性应该直接设到xhr上，下班了，下周再修复吧

:octocat: From gitme Android

@wendux wendux closed this as completed in b180b06 Aug 27, 2018
wendux pushed a commit that referenced this issue Aug 27, 2018
1. fix #12
2afc154 
2. Support attributes interception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wendux @sunsl516