Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] refine comment for mask, asr_model, convolution, ctc, encoder #1

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

robin1001
Copy link
Collaborator

Change-Id: I07495d8ea4ed9b5ba07150783d0fc65e99251653

Change-Id: I07495d8ea4ed9b5ba07150783d0fc65e99251653
"""Construct an ConvolutionModule object.
Args:
channels (int): The number of channels of conv layers.
kernel_size (int): Kernerl size of conv layers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo: kernerl

Change-Id: I1f2a31d336da2a76ce568835158e761a6fac3db2
@glynpu
Copy link
Contributor

glynpu commented Nov 25, 2020

+1

@robin1001 robin1001 added the documentation Improvements or additions to documentation label Nov 25, 2020
wenet/transformer/asr_model.py Outdated Show resolved Hide resolved
wenet/transformer/asr_model.py Outdated Show resolved Hide resolved
wenet/utils/mask.py Outdated Show resolved Hide resolved
Change-Id: I4d8a7e7f59001cd57d4b3d22e43e49f3bad65822
@glynpu
Copy link
Contributor

glynpu commented Nov 25, 2020

+1

@jschenxiaoyu jschenxiaoyu merged commit 47d081a into main Nov 25, 2020
@jschenxiaoyu jschenxiaoyu deleted the hotfix-comment branch November 25, 2020 07:35
robin1001 added a commit that referenced this pull request Jan 13, 2021
* [doc] refine comment for mask, asr_model, convolution, ctc, encoder

Change-Id: I07495d8ea4ed9b5ba07150783d0fc65e99251653

* [doc] fix topo error in convolution

Change-Id: I1f2a31d336da2a76ce568835158e761a6fac3db2

* [doc] remove blank

Change-Id: I4d8a7e7f59001cd57d4b3d22e43e49f3bad65822
This was referenced Jul 27, 2021
wantt referenced this pull request Apr 13, 2022
* [runtime] refactor decoder, asr_model to support more platforms

* fix topo error when rescoring

* support Copy for asr_model

* fix wrong check

* refine copy

* set inter-op thread
@zjc6666 zjc6666 mentioned this pull request Aug 8, 2022
@bboyxu5928 bboyxu5928 mentioned this pull request Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants