Merge pull request #547 from Ilhasoft/feature/change_requirements_to_…

…run_automatic_evaluate

change requirements to run automatic evaluate. Change 3 to 20 train phrases and remove minimal 15 totaly train phrases

bothub/common/models.py

@@ -383,13 +383,10 @@ def have_at_least_one_test_phrase_registered(self, language: str) -> bool:
     def have_at_least_two_intents_registered(self) -> bool:
         return len(self.intents()) >= 2
 
-    def have_at_least_fifteen_examples_registered(self, language: str) -> bool:
-        return self.examples(language=language).count() >= 15
-
-    def have_at_least_three_examples_for_each_intent(self, language: str) -> bool:
+    def have_at_least_twenty_examples_for_each_intent(self, language: str) -> bool:
         return all(
             [
-                self.examples(language=language).filter(intent__text=intent).count() > 3
+                self.examples(language=language).filter(intent__text=intent).count() >= 20
                 for intent in self.intents()
             ]
         )
@@ -411,14 +408,9 @@ def validate_if_can_run_automatic_evaluate(self, language: str) -> None:
                 _("You need to have at least " + "two registered intents")
             )
 
-        if not self.have_at_least_fifteen_examples_registered(language=language):
-            raise ValidationError(
-                _("You need to have at least " + "fifteen registered train phrases")
-            )
-
-        if not self.have_at_least_three_examples_for_each_intent(language=language):
+        if not self.have_at_least_twenty_examples_for_each_intent(language=language):
             raise ValidationError(
-                _("You need to have at least " + "three train phrases for each intent")
+                _("You need to have at least " + "twenty train phrases for each intent")
             )
 
     def request_nlp_train(self, user_authorization, data):

bothub/common/tests.py

@@ -368,13 +368,13 @@ def test_have_at_least_two_intents_registered(self):
         )
         self.assertTrue(self.repository.have_at_least_two_intents_registered())
 
-    def test_have_at_least_fifteen_examples_registered(self):
+    def test_have_at_least_twenty_examples_for_each_intent(self):
         self.assertFalse(
-            self.repository.have_at_least_fifteen_examples_registered(
+            self.repository.have_at_least_twenty_examples_for_each_intent(
                 language=languages.LANGUAGE_EN
             )
         )
-        for i in range(0, 15):
+        for i in range(0, 20):
             RepositoryExample.objects.create(
                 repository_version_language=self.repository.current_version(
                     languages.LANGUAGE_EN
@@ -383,27 +383,7 @@ def test_have_at_least_fifteen_examples_registered(self):
                 intent=self.example_intent_1,
             )
         self.assertTrue(
-            self.repository.have_at_least_fifteen_examples_registered(
-                language=languages.LANGUAGE_EN
-            )
-        )
-
-    def test_have_at_least_three_examples_for_each_intent(self):
-        self.assertFalse(
-            self.repository.have_at_least_three_examples_for_each_intent(
-                language=languages.LANGUAGE_EN
-            )
-        )
-        for i in range(0, 3):
-            RepositoryExample.objects.create(
-                repository_version_language=self.repository.current_version(
-                    languages.LANGUAGE_EN
-                ),
-                text=f"test{i}",
-                intent=self.example_intent_1,
-            )
-        self.assertTrue(
-            self.repository.have_at_least_three_examples_for_each_intent(
+            self.repository.have_at_least_twenty_examples_for_each_intent(
                 language=languages.LANGUAGE_EN
             )
         )
@@ -459,23 +439,22 @@ def test_request_nlp_automatic_evaluate(self, request_mock):
         intent_test = RepositoryIntent.objects.create(
             text="farewall", repository_version=self.repository_version
         )
-        for i in range(0, 8):
+        for i in range(0, 20):
             RepositoryExample.objects.create(
                 repository_version_language=self.repository.current_version(
                     languages.LANGUAGE_EN
                 ),
                 text=f"test{i}",
                 intent=intent_test,
             )
-        for i in range(0, 8):
+        for i in range(0, 20):
             RepositoryExample.objects.create(
                 repository_version_language=self.repository.current_version(
                     languages.LANGUAGE_EN
                 ),
                 text=f"test{i}",
                 intent=self.example_intent_1,
             )
-
         url = f"{self.repository.nlp_server if self.repository.nlp_server else settings.BOTHUB_NLP_BASE_URL}"
         url = f"{url}evaluate/"
         json = {