Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/persistor nlp #289

Merged
merged 10 commits into from
Oct 8, 2019
Merged

Hotfix/persistor nlp #289

merged 10 commits into from
Oct 8, 2019

Conversation

dyohan9
Copy link
Contributor

@dyohan9 dyohan9 commented Sep 30, 2019

No description provided.

@dyohan9 dyohan9 added the hotfix label Sep 30, 2019
@dyohan9 dyohan9 self-assigned this Sep 30, 2019
@coveralls
Copy link

coveralls commented Sep 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1783

  • 4 of 12 (33.33%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 95.953%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/api/v2/nlp/views.py 3 11 27.27%
Files with Coverage Reduction New Missed Lines %
bothub/api/v2/nlp/views.py 2 55.73%
Totals Coverage Status
Change from base Build 1756: -0.09%
Covered Lines: 6069
Relevant Lines: 6325
💛 - Coveralls

@dyohan9 dyohan9 requested review from edudouglas and removed request for VictorMeneghini October 1, 2019 12:44
@dyohan9 dyohan9 requested a review from Cloves23 October 1, 2019 19:00
@dyohan9 dyohan9 merged commit 496e9c3 into develop Oct 8, 2019
@dyohan9 dyohan9 deleted the hotfix/persistor_nlp branch October 8, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edudouglas edudouglas edudouglas approved these changes

@Cloves23 Cloves23 Awaiting requested review from Cloves23

Assignees

@dyohan9 dyohan9

Labels
hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dyohan9 @coveralls @edudouglas