Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #677

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Staging #677

merged 4 commits into from
Nov 23, 2021

Conversation

helllllllder
Copy link
Collaborator

What

  • Update the delete logs celery task to also delete the log in elasticsearch.
  • Disable delete related signals in the elasticsearch CelerySignalProcessor.

Why

The attempt of using signal+task wasn't fast enough to delete it from elasticsearch before deleting the instance in postgres, causing errors and not deleting it from elasticsearch.

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4293

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 80.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bothub/common/tasks.py 0 2 0.0%
bothub/common/signals.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
bothub/common/tasks.py 2 0%
Totals Coverage Status
Change from base Build 4282: -0.09%
Covered Lines: 4100
Relevant Lines: 5125

💛 - Coveralls

@helllllllder helllllllder merged commit e1ea7e9 into master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants