Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLOWS-34] - Fix: Ghost node position on canvas scroll #155

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[FLOWS-34] - Fix: Ghost node position on canvas scroll #155

merged 2 commits into from
Oct 27, 2023

Conversation

paulobernardoaf
Copy link

  • JSPlumb does consider the transformX/Y in the parentDiv of the elements, since your pan funcitonality depends on translating the canvas div, the managed plumbs were not being updated correctly. For that, we've made our own modification of the JSPlumb lib at version 2.13.1 that takes into consideration the translate state of the parent element when the ghost node is dragged

@paulobernardoaf paulobernardoaf merged commit 4ab28c1 into main Oct 27, 2023
3 checks passed
@paulobernardoaf paulobernardoaf deleted the fix/ghost-node-position-on-canvas-scroll branch February 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishsf luishsf luishsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paulobernardoaf @luishsf