[FLOWS-1331] - Fix: Remove external service empty parameters #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aldemylla
reviewed
Mar 20, 2024
src/components/flow/routers/externalservice/ExternalServiceRouterForm.tsx
Outdated
Show resolved
Hide resolved
Aldemylla
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Motivation and Context
On external services card, after saving the router the last parameter was an empty one, this was causing an error in mailroom
Summary of Changes
Removed empty parameters before saving it in the definition, and improved parameter validation to ensure that definition save will only occur after all non-empty parameters are valid