Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLOWS-1490] - Search field improvements #200

Merged
merged 11 commits into from
Apr 11, 2024
Merged

[FLOWS-1490] - Search field improvements #200

merged 11 commits into from
Apr 11, 2024

Conversation

acnormun
Copy link

@acnormun acnormun commented Apr 9, 2024

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

Removal of the browser default search card and add navigation through cards using the enter key.

Summary of Changes

Added prevent default to Ctrl+F and focus in text input, and a keydown listener to search card.

@acnormun acnormun changed the title Feat/search 1490 - Search field improvements Apr 9, 2024
src/components/canvas/Canvas.tsx Outdated Show resolved Hide resolved
src/components/search/SearchBar.tsx Outdated Show resolved Hide resolved
@Aldemylla Aldemylla changed the title 1490 - Search field improvements [FLOWS-1490] - Search field improvements Apr 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 61.10%. Comparing base (4f4b4d1) to head (c03c20c).
Report is 6 commits behind head on main.

Files Patch % Lines
src/components/canvas/Canvas.tsx 0.00% 6 Missing ⚠️
src/components/search/SearchBar.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   61.13%   61.10%   -0.04%     
==========================================
  Files         213      213              
  Lines        8668     8674       +6     
  Branches     2174     2175       +1     
==========================================
+ Hits         5299     5300       +1     
- Misses       2626     2631       +5     
  Partials      743      743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/components/search/SearchBar.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/canvas/Canvas.tsx Outdated Show resolved Hide resolved
src/components/search/SearchBar.tsx Outdated Show resolved Hide resolved
@acnormun acnormun merged commit ac50a22 into main Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants