Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for identifiers starting with an underscore #16

Closed
phillco opened this issue Sep 15, 2022 · 3 comments
Closed

Support for identifiers starting with an underscore #16

phillco opened this issue Sep 15, 2022 · 3 comments

Comments

@phillco
Copy link
Contributor

phillco commented Sep 15, 2022 

config/dictation/no_subtitles-sites.talon
Parse error on line 21 between column 10 and 21:
    speech._subtitles = 0
          ^^^^^^^^^^^^

The code in question:

settings():
    speech._subtitles = 0

Certain unstable Talon internal settings can be prefixed with underscores (like this one), so I think this should be allowed
@wenkokke
Copy link
Owner

Oh, yes! This is a tree-sitter-talon bug, though.

@wenkokke wenkokke mentioned this issue Sep 15, 2022
Closed
@wenkokke
Copy link
Owner

wenkokke commented Sep 15, 2022 •
edited

@philco Fixed in tree-sitter-talon. Should be fixed once I upgrade the dependencies. By the way, if you’d like, please submit your Talon files to the tree-sitter-talon tests (by editing script/examples or using the scripts in test).

@phillco
Copy link
Contributor Author

phillco commented Sep 15, 2022

Sure, will do.

wenkokke added a commit that referenced this issue Sep 27, 2022
@wenkokke
Fix #16; Fix #17
c222b28
@wenkokke wenkokke changed the title Settings with preceding underscores are not supported Support for identifiers starting with an underscore Sep 29, 2022
This was referenced Sep 29, 2022
Merged
Merged
phillco pushed a commit to talonhub/community that referenced this issue Sep 30, 2022
@wenkokke
Bump talonfmt version (#989)
4a005eb 
Fixes:

- Support for negative numbers
  <wenkokke/talonfmt#17>
- Support for settings with preceding underscores
  <wenkokke/talonfmt#16>
- Support for key bindings
  <wenkokke/talonfmt#8>
pull bot pushed a commit to wenkokke/talon-community that referenced this issue Oct 1, 2022
@wenkokke @pull
Bump talonfmt version (talonhub#989)
01cdb9c 
Fixes:

- Support for negative numbers
  <wenkokke/talonfmt#17>
- Support for settings with preceding underscores
  <wenkokke/talonfmt#16>
- Support for key bindings
  <wenkokke/talonfmt#8>
wenkokke added a commit that referenced this issue Oct 13, 2022
@wenkokke
Upstream extra (#28)
903dc7d 
* Update tree-sitter-talon

* Bump tree-sitter-talon & tree-sitter-type-provider

* Minor changes

* Test against minor versions of 3.9

* Bump tree-sitter-talon

* Remove restriction on
tree-sitter-type-provider

* Fix #16; Fix #17

* No tox

* Upstream extra methods

* Bump version

* Update lock file

* Fix extra import and empty check for matches

* Bump version 1.7.4 -> 1.8.0

* Relax language_version
nickvisut pushed a commit to nickvisut/knausj_talon that referenced this issue Nov 1, 2022
@wenkokke @nickvisut
Bump talonfmt version (talonhub#989)
92cfef9 
Fixes:

- Support for negative numbers
  <wenkokke/talonfmt#17>
- Support for settings with preceding underscores
  <wenkokke/talonfmt#16>
- Support for key bindings
  <wenkokke/talonfmt#8>
Spiteless pushed a commit to Spiteless/talonhub_community that referenced this issue Nov 9, 2022
@wenkokke @Spiteless
Bump talonfmt version (talonhub#989)
07d8f8c 
Fixes:

- Support for negative numbers
  <wenkokke/talonfmt#17>
- Support for settings with preceding underscores
  <wenkokke/talonfmt#16>
- Support for key bindings
  <wenkokke/talonfmt#8>
code-n-cool added a commit to code-n-cool/social-community that referenced this issue May 10, 2024
@code-n-cool
Bump talonfmt version (#989)
d7581b8 
Fixes:

- Support for negative numbers
  <wenkokke/talonfmt#17>
- Support for settings with preceding underscores
  <wenkokke/talonfmt#16>
- Support for key bindings
  <wenkokke/talonfmt#8>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillco @wenkokke