Skip to content

Commit

Permalink
bug fixed for pg sql parser 'with update', for issue alibaba#1727
Browse files Browse the repository at this point in the history
  • Loading branch information
wenshao committed May 10, 2017
1 parent 965ba2f commit 6c8169b
Show file tree
Hide file tree
Showing 2 changed files with 80 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,12 @@ public SQLStatement parseWith() {
stmt.setWith(with);
return stmt;
}

if (lexer.token() == Token.UPDATE) {
PGUpdateStatement stmt = (PGUpdateStatement) this.parseUpdateStatement();
stmt.setWith(with);
return stmt;
}
throw new ParserException("TODO");
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Copyright 1999-2017 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.druid.bvt.sql.postgresql.select;

import com.alibaba.druid.sql.SQLUtils;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.visitor.SchemaStatVisitor;
import com.alibaba.druid.util.JdbcConstants;
import junit.framework.TestCase;

import java.util.List;

public class PGSelectTest49 extends TestCase {
private final String dbType = JdbcConstants.POSTGRESQL;

public void test_0() throws Exception {
String sql = "WITH sel AS (SELECT\n" +
" unnest(ARRAY [4275]) AS gdid,\n" +
" unnest(ARRAY [1]) AS gdnumber)\n" +
"UPDATE goods_detail\n" +
"SET gd_number = gd_number - gdnumber FROM sel\n" +
"WHERE gd_id = gdid;";

List<SQLStatement> stmtList = SQLUtils.parseStatements(sql, dbType);
SQLStatement stmt = stmtList.get(0);

assertEquals("WITH\n" +
"\tsel\n" +
"\tAS\n" +
"\t(\n" +
"\t\tSELECT unnest(ARRAY[4275]) AS gdid, unnest(ARRAY[1]) AS gdnumber\n" +
"\t)\n" +
"UPDATE goods_detail\n" +
"SET gd_number = gd_number - gdnumber\n" +
"FROM sel\n" +
"WHERE gd_id = gdid", SQLUtils.toPGString(stmt));

assertEquals("with\n" +
"\tsel\n" +
"\tas\n" +
"\t(\n" +
"\t\tselect unnest(ARRAY[4275]) as gdid, unnest(ARRAY[1]) as gdnumber\n" +
"\t)\n" +
"update goods_detail\n" +
"set gd_number = gd_number - gdnumber\n" +
"from sel\n" +
"where gd_id = gdid", SQLUtils.toPGString(stmt, SQLUtils.DEFAULT_LCASE_FORMAT_OPTION));

assertEquals(1, stmtList.size());

SchemaStatVisitor visitor = SQLUtils.createSchemaStatVisitor(dbType);
stmt.accept(visitor);

// System.out.println("Tables : " + visitor.getTables());
// System.out.println("fields : " + visitor.getColumns());
// System.out.println("coditions : " + visitor.getConditions());

assertEquals(4, visitor.getColumns().size());
assertEquals(1, visitor.getTables().size());
}
}

0 comments on commit 6c8169b

Please sign in to comment.