Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on MVP #16

Merged
merged 19 commits into from
Feb 18, 2020
Merged

Work on MVP #16

merged 19 commits into from
Feb 18, 2020

Conversation

wentwrong
Copy link
Owner

@wentwrong wentwrong commented Feb 11, 2020 •
edited
Loading

Changes

@wentwrong wentwrong added this to the MVP milestone Feb 11, 2020
AndreyBelym
AndreyBelym reviewed Feb 11, 2020
View reviewed changes
src/router.js Outdated Show resolved Hide resolved
src/router.js Outdated Show resolved Hide resolved
@wentwrong
Divide into frontend and backend (resolve #17)
6505acf 
* Reogranization of directory structure
* New test for REST API endpoints
* New error-handling for Github API requests
* Pretty simple frontend with AJAX
AndreyBelym
AndreyBelym reviewed Feb 12, 2020
View reviewed changes
server/routes/api/index.js Outdated Show resolved Hide resolved
server/routes/api/index.js Outdated Show resolved Hide resolved
server/routes/router.js Outdated Show resolved Hide resolved
test/routes/index-test.js Show resolved Hide resolved
test/routes/index-test.js Outdated Show resolved Hide resolved
server/routes/api/index.js Outdated Show resolved Hide resolved
server/config.js Outdated Show resolved Hide resolved
test/routes/index-test.js Outdated Show resolved Hide resolved
AndreyBelym
AndreyBelym reviewed Feb 14, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/server/app.js Outdated Show resolved Hide resolved
src/server/my-server.js Outdated Show resolved Hide resolved
@wentwrong
Mock github API endpoints
9e8e4d7 
* Mock github App inherited from main App
* One integration test for REST-API
* Fix grammar a little bit
@wentwrong
Add .eslintrc for client side code
1368d0f
@wentwrong
Replace morgan with custom middleware logger
e5161b3
This was linked to issues Feb 14, 2020
Dividing frontend from backend #17
Closed
MVP Prototype #12
Closed
AndreyBelym
AndreyBelym reviewed Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@AndreyBelym AndreyBelym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost happy :) Let's work out the remaining questions.

package.json Outdated Show resolved Hide resolved
src/server/createRoutes.js Outdated Show resolved Hide resolved
test/routes/static-test.js Outdated Show resolved Hide resolved
test/mock-github-app.js Outdated Show resolved Hide resolved
src/server/server.js Show resolved Hide resolved
src/server/config.js Outdated Show resolved Hide resolved
AndreyBelym
AndreyBelym reviewed Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@AndreyBelym AndreyBelym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some stylistic notes :)

src/server/config.js Outdated Show resolved Hide resolved
src/server/configexpress.js Outdated Show resolved Hide resolved
src/server/server.js Outdated Show resolved Hide resolved
src/server/server.js Outdated Show resolved Hide resolved
@AndreyBelym AndreyBelym mentioned this pull request Feb 18, 2020
Closed
@AndreyBelym AndreyBelym merged commit fb75a50 into master Feb 18, 2020
@wentwrong wentwrong deleted the refactor-app branch February 25, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Dividing frontend from backend Need some kind of template engine MVP Prototype
2 participants
@wentwrong @AndreyBelym