Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting on rowspan tbody breaks table #3462

Open
krassowski opened this issue Nov 22, 2017 · 5 comments
Open

Sorting on rowspan tbody breaks table #3462

krassowski opened this issue Nov 22, 2017 · 5 comments
Assignees
@djhvscf
Labels
confirmed Issues that have been confirmed with a reduced test case and identify a bug. core Issues stemming from our compiled or source JavaScript files.

Comments

@krassowski
Copy link

When sorting a table with data having a defined rowspan causes the "child" rows within the group of rows to disassociated and break rendered improperly.
jsfiddle. Please see following animation:

ezgif-5-caeb0ca3a9
@krassowski
Copy link
Author

Possibly related to: #3400, #2295 and #823.

@krassowski
Copy link
Author

A less popular drvic10k/bootstrap-sortable manages to handles this case in a clever way, using as many duplicates of rowspan cells as needed to keep a table properly formatted: https://jsfiddle.net/jz5tnq4y/15/.

peek 2017-11-23 15-20
Here is the commit which enabled this, just as reference if @wenzhixin agrees on having this future in and someone was interested in implementing it: drvic10k/bootstrap-sortable@0df36e9. Btw. the code is on MIT license too, so heavy inspiration should not be a problem (if acknowledged).

@wenzhixin wenzhixin added confirmed Issues that have been confirmed with a reduced test case and identify a bug. core Issues stemming from our compiled or source JavaScript files. labels Nov 30, 2017
@vaibhav101
Copy link

Has there been any development on this issue?

@UtechtDustin
Copy link
Collaborator

@vaibhav101
Currently not, but any PR is welcome!

@djhvscf djhvscf self-assigned this Nov 16, 2019
@wenzhixin wenzhixin mentioned this issue Feb 25, 2020
Closed
@RShah512
Copy link

Is there any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djhvscf djhvscf

Labels
confirmed Issues that have been confirmed with a reduced test case and identify a bug. core Issues stemming from our compiled or source JavaScript files.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@wenzhixin @djhvscf @krassowski @RShah512 @vaibhav101 @UtechtDustin