Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own Theme for the bootstrap-table #4403

Merged
merged 21 commits into from Jun 27, 2020
Merged

Own Theme for the bootstrap-table #4403

merged 21 commits into from Jun 27, 2020

Conversation

UtechtDustin
Copy link
Collaborator

@UtechtDustin UtechtDustin commented Jun 10, 2019

fix #4364

  • Accent Neutralise
  • Addrbar
  • Auto Refresh
  • Cookie
  • Copy Rows
  • Defer Url
  • Editable
  • Export
  • Filter Control
  • Fixed Columns
  • Group By V2
  • I18n Enhance
  • Key Events
  • Mobile
  • Multiple Sort
  • Page Jump To
  • Print
  • Reorder Columns
  • Reorder Rows
  • Resizable
  • Sticky Header
  • Toolbar
  • Treegrid

@djhvscf
Copy link
Collaborator

djhvscf commented Jun 10, 2019

Updating branch with develop

@UtechtDustin UtechtDustin changed the title WIP: First (s)css for the bootrap-table theme WIP: Own Theme for the bootstrap-table Jun 11, 2019
@UtechtDustin
Copy link
Collaborator Author

Added a list of checked extensions.

@UtechtDustin UtechtDustin changed the title WIP: Own Theme for the bootstrap-table Own Theme for the bootstrap-table Feb 8, 2020
@UtechtDustin
Copy link
Collaborator Author

@wenzhixin @djhvscf
Can be tested now, i cant provide example because the editor (obviously) dont have that theme yet.
Please test it locally.

@djhvscf
Copy link
Collaborator

djhvscf commented Feb 8, 2020

I'm testing this

Copy link
Collaborator

@djhvscf djhvscf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error

image

@UtechtDustin
Copy link
Collaborator Author

UtechtDustin commented Feb 8, 2020

Which command do you executed ?
The pre-commit script said anything is fine :o
yarn build also worked fine.

@djhvscf
Copy link
Collaborator

djhvscf commented Feb 8, 2020

Which command do you executed ?
The pre-commit script said anything is fine :o
yarn build also worked fine.

Yes, yarn build

image

@UtechtDustin
Copy link
Collaborator Author

Do you have the newest commit ?
Its weired because yarn build runs without erros for me, also your errors dont match with my lines.

@djhvscf
Copy link
Collaborator

djhvscf commented Feb 8, 2020

Do you have the newest commit ?
Its weired because yarn build runs without erros for me, also your errors dont match with my lines.

Yes,

git pull origin
yarn install
yarn build

image

@djhvscf
Copy link
Collaborator

djhvscf commented Feb 8, 2020

@wenzhixin could you try this branch?

@UtechtDustin
Copy link
Collaborator Author

@djhvscf i guess i found the issue, please try again

@djhvscf
Copy link
Collaborator

djhvscf commented Feb 9, 2020

@djhvscf i guess i found the issue, please try again

The issue is still happening

image

@wenzhixin
Copy link
Owner

@UtechtDustin there are 27 commits and some are unnecessary, so we need to rebase the develop branch, you can use this command:

git rebase develop

@wenzhixin
Copy link
Owner

@djhvscf I don't find the build problem. Maybe it causes only in Windows.

Copy link
Owner

@wenzhixin wenzhixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • font.scss need to update to _font.scss
  • variables.scss -> _variables.scss

@UtechtDustin
Copy link
Collaborator Author

Rebase and renaming of the files are done :-)

@wenzhixin
Copy link
Owner

The examples cannot work:

@UtechtDustin
Copy link
Collaborator Author

@djhvscf @wenzhixin before you merge it, the icons still dont work on the live editor.

@wenzhixin
Copy link
Owner

@UtechtDustin
Copy link
Collaborator Author

@wenzhixin its not working for me.
Bildschirmfoto von 2020-06-25 18-51-19

downloadable font: rejected by sanitizer (font-family: "bootstrap-table" style:normal weight:400 stretch:100 src index:1) source: https://live.bootstrap-table.com/fonts/bootstrap-table.ttf
downloadable font: rejected by sanitizer (font-family: "bootstrap-table" style:normal weight:400 stretch:100 src index:2) source: https://live.bootstrap-table.com/fonts/bootstrap-table.woff

Browser: Firefox 77.0.1

@wenzhixin
Copy link
Owner

It's OK using firefox, have you clear the cache?

image

@UtechtDustin
Copy link
Collaborator Author

@wenzhixin Sure i always clear the cache, im not sure why this happens.
Its only happen on the editor, localy its working fine. It also works fine on a other computer, so i guess its fine and can be merged.

@wenzhixin wenzhixin merged commit 7e10099 into develop Jun 27, 2020
@wenzhixin wenzhixin deleted the feature/4364 branch June 27, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage without any framework
3 participants