Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boostrap 5 integration error #5522

Closed
ClicShopping opened this issue Jan 4, 2021 · 2 comments · Fixed by #5536
Closed

Boostrap 5 integration error #5522

ClicShopping opened this issue Jan 4, 2021 · 2 comments · Fixed by #5536
Labels
bootstrap5 confirmed Issues that have been confirmed with a reduced test case and identify a bug. has PR Issues that has been fixed with a PR.

Comments

@ClicShopping
Copy link

Hello,

the code source of this page is based on boostrap4.5. https://examples.bootstrap-table.com/index.html?bootstrap5# not on 5.

You can see there: https://www.clicshopping.com/ClicShoppingAdmin835 a version with boostrap5 and bootstrap table 1.18.1.
For example
Look catalog / products
Look Report/Products/viewev (export)
As you see all do not work properly.
Regards

<table
    id="table"
    data-bs-toggle="table" ====> add bs as new table syntax bootstrap 5
    data-id-field="selected" ===> ok
    data-select-item-name="selected[]" ====> ok
    data-click-to-select="true" 
    data-sort-order="asc" ===> ok
    data-sort-name="sort_order" ===> ok
    data-toolbar="#toolbar" ===> design 
    data-buttons-class="primary"
    data-show-toggle="true" =====> see a little pb on button aligment
    data-show-columns="true"  ====> not ok
    data-mobile-responsive="true"
   data-show-export="true" ===> not ok
>

Suggestion, if you can remove Jquery (bootstrap 5 do use jquery anymore), it will be better

Originally posted by @oitsuki in #5515 (comment)

@ClicShopping ClicShopping changed the title Hello, Boostrap 5 integration error Jan 5, 2021
@oitsuki
Copy link

oitsuki commented Jan 11, 2021

the float does not work : float-left is float-start for example
data-toggle become data-bs-toggle ....

@wenzhixin wenzhixin added the has PR Issues that has been fixed with a PR. label Jan 11, 2021
@wenzhixin
Copy link
Owner

Fixed in #5536

@wenzhixin wenzhixin added confirmed Issues that have been confirmed with a reduced test case and identify a bug. bootstrap5 labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap5 confirmed Issues that have been confirmed with a reduced test case and identify a bug. has PR Issues that has been fixed with a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants