Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie + filter-control extension #5960

Closed
yeezy69 opened this issue Nov 21, 2021 · 2 comments · Fixed by #5583
Closed

cookie + filter-control extension #5960

yeezy69 opened this issue Nov 21, 2021 · 2 comments · Fixed by #5583
Assignees
Labels
Bug Issues which are marked as Bug cookie Issues for the cookie extension. filter-control Issues for the filter-control extension. fixed Issues already fixed in develop branch or a pull request. has PR Issues that has been fixed with a PR.

Comments

@yeezy69
Copy link

yeezy69 commented Nov 21, 2021

Bootstraptable version(s) affected

1.19.1

Description

With commit a4d2918 from pull request #5959 the filter-control extension works again. Before this commit, the input-fields lost the text entered, and select-fields lost the selected value. See bug #5828.

But now in conjunction with the cookie-extension, the select-fields didn't remember his value:

2021-11-21 15-48-40

In my Online-Editor Example you have to input "a4d2918" as GitHub src branch in Libaries.

Example(s)

https://live.bootstrap-table.com/code/yeezy69/9673

Possible Solutions

No response

Additional Context

No response

@yeezy69 yeezy69 added the Bug Issues which are marked as Bug label Nov 21, 2021
@djhvscf djhvscf self-assigned this Nov 22, 2021
@djhvscf
Copy link
Collaborator

djhvscf commented Nov 23, 2021

This is fixed in: #5583

Example with fix: https://live.bootstrap-table.com/code/djhvscf/9696

@djhvscf djhvscf added cookie Issues for the cookie extension. filter-control Issues for the filter-control extension. fixed Issues already fixed in develop branch or a pull request. has PR Issues that has been fixed with a PR. labels Nov 23, 2021
@djhvscf djhvscf mentioned this issue Nov 23, 2021
36 tasks
@albfan
Copy link
Contributor

albfan commented Apr 19, 2022

I found a corner case for this:

If you reuse the table to show different data (like toggling with a dropdown)

filter+cookie+reuse-table

https://live.bootstrap-table.com/code/albfan/11219

you can see that search text is correctly handling on change, but filter columns are always stored as last value set. There're some timeouts triggered on off event handlers that trigger cookies for all tables to store last value

here I use same columns and data, but it fails just if column is the same.

You can see search text changes from 19 and 21 between tables, but columns filter name which is 8 for tableA, once modified to 5 in tableB keeps that value after return to tableA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues which are marked as Bug cookie Issues for the cookie extension. filter-control Issues for the filter-control extension. fixed Issues already fixed in develop branch or a pull request. has PR Issues that has been fixed with a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants