Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The filter-control input is clearing while searching #5828

Closed
matheusilario opened this issue Aug 12, 2021 · 4 comments · Fixed by #5583
Closed

The filter-control input is clearing while searching #5828

matheusilario opened this issue Aug 12, 2021 · 4 comments · Fixed by #5583
Labels
confirmed Issues that have been confirmed with a reduced test case and identify a bug. filter-control Issues for the filter-control extension. fixed Issues already fixed in develop branch or a pull request. has PR Issues that has been fixed with a PR.

Comments

@matheusilario
Copy link

The filter-control input is clearing while searching and the filter cannot be cleared.

Tried to change table settings but it persists.

screencast

An example of my table configuration:

https://live.bootstrap-table.com/code/matheusilario/8621

This example works perfectly. But in the image you can see that in the application no.
@matheusilario matheusilario added the help-wanted Issues we need or would love help from the community to resolve. label Aug 12, 2021
@UtechtDustin
Copy link
Collaborator

Example: https://live.bootstrap-table.com/code/yeezy69/9585

@UtechtDustin UtechtDustin added confirmed Issues that have been confirmed with a reduced test case and identify a bug. filter-control Issues for the filter-control extension. labels Nov 11, 2021
@UtechtDustin UtechtDustin mentioned this issue Nov 11, 2021
Closed
@djhvscf
Copy link
Collaborator

djhvscf commented Nov 11, 2021

I think this is because we're removing the controls and then recreating them.. We need to dig deeper on this

@yeezy69
Copy link

yeezy69 commented Nov 15, 2021 •
edited

I compared version 1.19.1 with 1.18.3 in browser dev-tools. In version 1.19.1 the whole tablehead will be removed and recreated after a search is performed. In version 1.18.3 not.

@UtechtDustin UtechtDustin mentioned this issue Nov 19, 2021
Closed
@whizzrd whizzrd mentioned this issue Nov 21, 2021
Closed
10 tasks
@yeezy69 yeezy69 mentioned this issue Nov 21, 2021
Closed
djhvscf added a commit that referenced this issue Nov 25, 2021
@djhvscf
Fix #5828
3b1b912
@djhvscf
Copy link
Collaborator

djhvscf commented Nov 25, 2021

Example with fix: https://live.bootstrap-table.com/code/djhvscf/9721

@djhvscf djhvscf mentioned this issue Nov 25, 2021
Merged
36 tasks
@djhvscf djhvscf added fixed Issues already fixed in develop branch or a pull request. has PR Issues that has been fixed with a PR. and removed help-wanted Issues we need or would love help from the community to resolve. labels Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed Issues that have been confirmed with a reduced test case and identify a bug. filter-control Issues for the filter-control extension. fixed Issues already fixed in develop branch or a pull request. has PR Issues that has been fixed with a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improving filter control wenzhixin/bootstrap-table
fix/5828 whizzrd/bootstrap-table
4 participants
@djhvscf @matheusilario @UtechtDustin @yeezy69