Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impoved Search - Added check for comperations (<,>,<=,=<,>=,=>) #4218

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Impoved Search - Added check for comperations (<,>,<=,=<,>=,=>) #4218

merged 3 commits into from
Mar 22, 2019

Conversation

UtechtDustin
Copy link
Collaborator

I impoved the search checks so comperations search (<,>,<=,=<,>=,=>) are possible now.
This feature was requested by @ManicPumpkin on Issue #3042.

The following comperations are possible:

> value
< value
<= value
=< value
>= value
=> value
value <
value >
value <=
value =<
value >=
value =>

JsFiddle Demo: https://jsfiddle.net/s2gpvoqu/

@UtechtDustin UtechtDustin changed the title Added check for comperations search (<,>,<=,=<,>=,=>) Impoved Search - Added check for comperations (<,>,<=,=<,>=,=>) Mar 20, 2019
@wenzhixin
Copy link
Owner

Thanks for your contribution!

It seems that there are problems in this case, let's see how to improve it.

@wenzhixin wenzhixin added the feature Issues asking for a new feature to be added, or an existing one to be extended or modified. label Mar 21, 2019
@UtechtDustin
Copy link
Collaborator Author

I fixed the bug (working example), also i improved the documentation about searching (description of the 3 search types (contains, strict and comparison)).

@wenzhixin wenzhixin merged commit d442e80 into wenzhixin:develop Mar 22, 2019
wenzhixin added a commit that referenced this pull request Mar 22, 2019
@wenzhixin
Copy link
Owner

Thanks! Fixed the lint errors: d6b1c78.

@UtechtDustin
Copy link
Collaborator Author

@wenzhixin
My fault i already fixt hat lint errors, but forgott to push it...sorry!
Can you explain me why all ; will removed, is there a good reason for that or just to save some memory ?

@UtechtDustin UtechtDustin deleted the Falseee/feature/issue-3042 branch March 22, 2019 19:58
@wenzhixin
Copy link
Owner

Because other ES6 projects remove ;, so use the same rules, each line can be one less character :)
Also, refer to some of the more popular projects, they also do not use ;.
For examples:
https://github.com/twbs/bootstrap/blob/master/js/src/alert.js
https://github.com/vuejs/vue/blob/dev/src/core/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues asking for a new feature to be added, or an existing one to be extended or modified.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants