Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-sort #5489

Closed
wants to merge 1 commit into from
Closed

Fix multi-sort #5489

wants to merge 1 commit into from

Conversation

Naruto-kyun
Copy link
Contributor

this.data is change, then this.initBody() load this.options.data, so reorder this.options.data instead

Bug fix?
yes

New Feature?
no

Resolve an issue?
Fix #4616

Example(s)?
Do manual asc on both columns
Before: https://live.bootstrap-table.com/code/wenzhixin/853
After: https://live.bootstrap-table.com/code/Naruto-kyun/5802

this.data is change, then this.initBody() load this.options.data, so reorder this.options.data instead
Copy link
Collaborator

@UtechtDustin UtechtDustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that would fix this problem, but it would create new issues.
With youre change the original data would be sorted!

We have to find a other way to solve that, but thanks for the try :-)

@wenzhixin
Copy link
Owner

@UtechtDustin is right, for example, use the sortReset option will show the problem: https://live.bootstrap-table.com/code/wenzhixin/5832.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple-sort extension dont work (only update the icons)
3 participants