Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Table Multiple Sort extension #919

Merged
merged 4 commits into from May 25, 2015
Merged

Bootstrap Table Multiple Sort extension #919

merged 4 commits into from May 25, 2015

Conversation

dimbslmh
Copy link
Contributor

Hi @wenzhixin ,

I made this extension for sorting by multiple columns #70:

http://jsfiddle.net/dimbslmh/s2h1gzj9/

Initial release of Bootstrap Table Multiple Sort.
Initial release of README for Bootstrap Table Multiple Sort extension.
@dimbslmh dimbslmh mentioned this pull request May 25, 2015
@wenzhixin
Copy link
Owner

Great!!! Thanks @dimbslmh

wenzhixin added a commit that referenced this pull request May 25, 2015
Bootstrap Table Multiple Sort extension
@wenzhixin wenzhixin merged commit f729895 into wenzhixin:master May 25, 2015
@jtrumbull
Copy link

@dimbslmh: Great extension! Excited to start playing around with this.

Do you guys think it would be appropriate to come up with a procedure for creating an extension, and adding it to the CONTRIBUTING.md?

One suggestion you may consider is having a separate repository for each extension. This would allow for the extension developer to manage pull requests on their project, then the core developer to manage pull requests of the extension into the root library.

I.e.

Creating an extension

  1. Create a separate repository for your extension [username]/bootstrap-table-your-extension
  2. Fork the bootstrap-table project (See steps 1-3 in Pull requests)
  3. Add/Modify your-extension at src/extensions/your-extension
  4. Continue through steps 4-6 in Pull requests.
  5. Create a pull request for your extension (Step 7 in Pull requests).

Just a thought, wasn't sure where else to post general discussion.

@dimbslmh
Copy link
Contributor Author

@wenzhixin @jtrumbul Thank you.

@jtrumbul Yeah, is see what you mean. I forgot to create my own separate repository of the extension (separated from the main bootstrap-table repository).

@djhvscf
Copy link
Collaborator

djhvscf commented May 25, 2015

@jtrumbull I agree with that.. good idea.. what do you think @wenzhixin ?

@djhvscf
Copy link
Collaborator

djhvscf commented May 25, 2015

No problem @dimbslmh we are trying to define the process! ;)

@wenzhixin
Copy link
Owner

Thanks for your advice @jtrumbull, that sounds great! Just what I said in Using the issue tracker, it is better for the extension developer to manage their extension project.

@wenzhixin
Copy link
Owner

Can you help to add the process to CONTRIBUTING.md @jtrumbull ?

@wenzhixin
Copy link
Owner

@dimbslmh if you have time it is great to add an example to bootstrap-table-examples repo :), pull request is welcome.

@jtrumbull
Copy link

@wenzhixin: Sure thing, i'll write something up.

@dimbslmh
Copy link
Contributor Author

@wenzhixin Yes, I'll try to make one now.

@dimbslmh
Copy link
Contributor Author

@wenzhixin See multiple-sort.html

wenzhixin added a commit that referenced this pull request May 25, 2015
@dimbslmh
Copy link
Contributor Author

Please let me know if you find any bugs. Thank you.

@djhvscf
Copy link
Collaborator

djhvscf commented May 25, 2015

Ok, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants