Log topic and table name when a row fails to be inserted into BQ #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criccomini
approved these changes
Oct 4, 2019
mtagle
reviewed
Oct 4, 2019
| List<InsertAllRequest.RowToInsert> failRows = new ArrayList<>(); | ||
| for (int index = 0; index < rows.size(); index++) { | ||
| if (failRowsSet.contains((long)index)) { | ||
| logger.debug("[row with index {}]: failed", index); | ||
| logger.debug("Row with index {} from topic {} failed to be written to table {}.", index, topic, table.getFullTableName()); |
There was a problem hiding this comment.
I feel like this is a good time to maybe move this log message outside of the for loop so we don't get a big stack of errors, but instead one error message that contains all the indexes that failed.
There was a problem hiding this comment.
I feel like this is a good time to maybe move this log message outside of the for loop so we don't get a big stack of errors, but instead one error message that contains all the indexes that failed.
@mtagle Understood, updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.