New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort bank demo on error #59
Conversation
Please keep the format of messages of the action result consistent. |
I (mostly) reverted the messages. Moved some to only be before the call, so that it is more clear what has failed if a failure occurs. Is this what you were thinking? |
This test needs to fail early (for exampe, if dockerd is not running!). If the modifications I've made to the comments are a concern, please be specific. |
Is there any particular reason to switch some of |
No particular reason, just habit. I've found that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the demo bank app doesn't check whether dependent containers are running, the app can still seem to be stuck if it runs without starting the waltz cluster.
I was gettin failures that were hard to track down because docker commands early in the script would fail, but the error messages are obscured because the script blindly continues. By aborting early on a failure, it is much easier to notice errors.