Fix corporatedomains whois created/expires on format #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix date parsing in AFNIC parsers as the format had changed from DD/MM/YYYY to YYYY-MM-DDThh:mm:ssZ.
Updated the WHOIS parser for corporatedomains which were incorrectly parsing "Registrar Registration Expiration Date", because the date had "MM/DD/YYYY" format rather than "DD/MM/YYYY". The change updates the format if the value has slash-separated date before passing it into `parse_time`. This change cannot be used for all dates, since some dates use a dash-separated format (i.e. YYYY-MM-DDTHH:MM:SSZ). This problem also applies to the creation date as well when parsing the value for "Creation Date".
Moved the existing `status_available` files into the `com` folder where the new `status_registered` files will be generated. Generated new `status_registered` files for the different cases when the creation and expiration dates are hyphen-separated vs slash-separated. Also re-used the existing `.expected` file from the old `status_registered` file to test for the new values.
Return the result from `Time.utc` to parse dates using slash-format in corporatedomains, since this would avoid using joins and string interpolation before being passed into `parse_time`. Renamed the method as the return value now returns a Time object rather than a string.
njng
changed the title
weppos
requested changes
Jun 25, 2019
|
Since it was branched from another branch, I created a new PR which only contains those changes: #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the responses return the creation/expiration date in a format that is parsed incorrectly through
parse_time. This occurs specifically for corporatedomains in some instances where the date format is returned as "MM/DD/YYYY", but is interpreted as "DD/MM/YYYY" so these dates need to be parsed separately.