Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not intelligent when over quota for second part #319

Closed
dv opened this issue Apr 10, 2014 · 3 comments
Closed

Not intelligent when over quota for second part #319

dv opened this issue Apr 10, 2014 · 3 comments
Labels

Comments

@dv
Copy link

dv commented Apr 10, 2014

I've whois'ed google.com until the second part was over quota (i.e. first part from verisign was OK, but the second part, from markmonitor, returns:
#<struct Whois::Record::Part body="You have exceeded your quota of queries.\n", host="whois.markmonitor.com">

In this, case if I run this updated_on, created_on and expires_on are all 'nil', even though they are defined and parsed correctly in the first part:

g = Whois.whois("google.com")
g.created_on # => nil
g.updated_on # => nil
g.expires_on # => nil

p = Whois::Record::Parser.parser_for(g.parts.first)
p.created_on # => 1997-09-15 00:00:00 +0300
p.expires_on # => 2020-09-14 00:00:00 +0300
p.updated_on # => 2011-07-20 00:00:00 +0300

This is not very logical and also goes against what you described in your documentation, I think.

@dv
Copy link
Author

dv commented Apr 10, 2014

Related to this, the second part parser does not have a response_throttled? method. I thought this was part of all parsers?

@weppos
Copy link
Owner

weppos commented Nov 16, 2014

response_throttled? is implemented only for those responses where I was able to collect a sample. Feel free to provide a patch.

@weppos weppos added the parser label Dec 25, 2015
@weppos
Copy link
Owner

weppos commented Jun 9, 2016

Closing as this is a very old topic and the parsers have been moved to https://github.com/weppos/whois-parser

@weppos weppos closed this as completed Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants