Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ngrok command flag. #622

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix ngrok command flag. #622

merged 1 commit into from
Oct 12, 2023

Conversation

NSHenry
Copy link

@NSHenry NSHenry commented Oct 7, 2023

  • There is an issue ticket which accompanies my PR: .
  • I have followed the guidelines for contributing.
  • I have checked that there aren't other open pull requests for the same issue ticket.
  • I have formatted my code with the PSR-2 coding style before submitting my PR.

I have read the contribution guidelines and am targeting the branch 2.x:
Because this is a Bug Fix which is Backwards Compatible.

Changelog entry:

[2.4.1]

Fixed

@NSHenry
Fix ngrok parameter.
051b9fa 
`valet share` was throwing the error `ERROR:  unknown shorthand flag: 'o' in -ost-header=rewrite` when run.
@NSHenry NSHenry changed the title Fix ngrok command flag #621 Fix ngrok command flag. Oct 7, 2023
@mischabraam mischabraam merged commit 55a3fb8 into weprovide:2.x Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NSHenry @mischabraam