Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSRI-9: Tagging authors #1147

Merged
merged 7 commits into from Jan 23, 2024
Merged

TSRI-9: Tagging authors #1147

merged 7 commits into from Jan 23, 2024

Conversation

michael-scheurer
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f45a9c7) 34.53% compared to head (24aaec0) 34.72%.

Files Patch % Lines
libs/ui/editor/src/lib/panel/authorEditPanel.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   34.53%   34.72%   +0.19%     
==========================================
  Files         428      430       +2     
  Lines       11442    11501      +59     
  Branches     2496     2506      +10     
==========================================
+ Hits         3951     3994      +43     
- Misses       7283     7294      +11     
- Partials      208      213       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Itrulia
Itrulia previously approved these changes Jan 23, 2024
Copy link
Contributor

@antkiewiczk antkiewiczk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please merge master and try to update snapshots, also please fix linting, then it will be good to go :)

@michael-scheurer
Copy link
Collaborator Author

thanks for the reviews. just fixed linting and tests.

@michael-scheurer michael-scheurer merged commit 012b0cd into master Jan 23, 2024
11 checks passed
@michael-scheurer michael-scheurer deleted the TSRI-9-tagging-team branch January 23, 2024 13:22
This was referenced Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants