Display dashboard actions in correct order #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penk85
requested review from
LukasSkywalker,
Itrulia,
antkiewiczk and
elias-summermatter
|
PR 879 with branch
|
Itrulia
approved these changes
Mar 21, 2023
Itrulia
reviewed
Mar 21, 2023
| @@ -138,5 +138,5 @@ export const getActions = async ( | |||
| await Promise.all([articles, pages, comments, authors, subscriptions, polls, users, events]) | |||
| ).flat() | |||
|
|
|||
| return actions.sort((v1: Action, v2: Action) => v2.date.getDate() - v1.date.getDate()) | |||
| return actions.sort((v1: Action, v2: Action) => v2.date.getTime() - v1.date.getTime()) | |||
There was a problem hiding this comment.
Suggested change
| return actions.sort((v1: Action, v2: Action) => v2.date.getTime() - v1.date.getTime()) | |
| return actions.sort((v1: Action, v2: Action) => v2.date - v1.date) |
There was a problem hiding this comment.
@Itrulia the sort won't work with Date type so I needed it as a number.
There was a problem hiding this comment.
Yeah this will make it a number
There was a problem hiding this comment.
Actually you're right it should work, but ts shows error.
antkiewiczk
approved these changes
Mar 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPC-1118: Dashboard action were displaying in wrong order. This fixes where the sort order in the api wasn't working properly.