Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page improvements #880

Merged
merged 17 commits into from
Mar 29, 2023
Merged

Conversation

penk85
Copy link
Contributor

@penk85 penk85 commented Mar 22, 2023

WPC-1081: Improvements on settings page:

  • ✔️ disable save button if nothing is changed
  • ✔️ introduce cancel button to undo the unsaved changes
  • ✔️ throw warning when clicking on save: i.e. “are you sure you want to change these settings?” with the details of what settings will be updated
  • ✔️ Added missing setting for invoice reminder max tries
  • throw warning when try to leave page with unsaved changes: this is partially implemented with the warning showing when user refreshes the page, closes the tab or other window events but does not get triggered from React route changes. This should be handled in a separate ticket.

@penk85 penk85 self-assigned this Mar 22, 2023
@github-actions
Copy link

PR 880 with branch wpc-1081-settings-unsaved-changes-dialog has been deployed to:

@penk85 penk85 marked this pull request as ready for review March 28, 2023 14:19
@penk85 penk85 merged commit cbb0459 into master Mar 29, 2023
@penk85 penk85 deleted the wpc-1081-settings-unsaved-changes-dialog branch March 29, 2023 13:52
@tomaszdurka tomaszdurka mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants