Helm v2.17.0 for werf #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend `kube.Client` implementation of `environment.KubeClient` interface with ResourcesWaiter object. ResourcesWaiter interface defines `WaitForResources` and `WatchUntilReady` methods and allows to redefine default waiting behaviour in custom helm builds. For example, to add logging of resources statuses, errors, pod's logs while waiting. Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
Cannot use go module converted from glide due to error: kubernetes/kubernetes#79384. Update k8s.io go deps to 1.16.0.
Write 3-way-merge and 2-way-merge patches to annotations: ``` debug.werf.io/repair-patch debug.werf.io/repair-patch-errors ``` Repair patch is a 3-way-merge kubectl-apply-like patch between current live resource state and desired chart state. User should apply this patch manually when live resource state is out of sync with the chart configuration resource state. A warning message will be written to the screen during deploy process when repair patch is not empty.
…pair patches - Create two-pass patch as follows: current object => apply 2 way merge helm patch => create 3 way merge first stage repair patch => apply first stage repair patch => create actual repair patch. - Filter out unnecessary fields during patch creation (such as volumeClaimTemplates, empty container/env values). - Normalize numeric limits and (100Gi, 1000m, etc.).
- Manually cut out repair patch fields: $setElementsOrder, $retainKeys, spec.strategy.rollingUpdate=null. - Validate chart templates, write log warnings, add object annotation `debug.werf.io/validation-messages`. - Improved repair-patch creation to filter out invalid non-existing fields described in the chart template.
…lStrict everywhere
…h an error has been added to the chart
…ook that already exists
…ix error messages
The problem occurs when the following conditions are met: * A chart does not contain Chart.yaml file. * There is an invalid sub chart that does not pass validation.
distorhead
added a commit
to werf/werf
that referenced
this pull request
Nov 6, 2020
errPending on upgrade could occur when some deploy has been interrupted by a signal. In this case helm leave release in inconsistent state which could not be healed by automatical redeploy. Werf uses own distributed release locking by release name using Kubernetes configmap annotations to synchronize multiple deploy processes. Werf implementation supports interrupting of werf-deploy process by some signal.
[v2.17.0][helm for werf] Remove errPending on upgrade
distorhead
added a commit
to werf/werf
that referenced
this pull request
Nov 9, 2020
…ck) is in progress' error werf/3p-helm#61
…to allow usage of anchors
[v2.17.0][helm for werf] Do not parse values with strict yaml parser to allow usage of yaml-anchors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.