Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API. Closes #5143 #5144

Closed
wants to merge 2 commits into from
Closed

Update API. Closes #5143 #5144

wants to merge 2 commits into from

Conversation

gyrter
Copy link
Contributor

@gyrter gyrter commented Dec 12, 2022

API Update for relesed Selectel CRaaS

@gyrter gyrter marked this pull request as draft December 12, 2022 11:02
@gyrter
Copy link
Contributor Author

gyrter commented Dec 13, 2022

I got strange result. CleanUp trying to get strange manifest

2m17.1113939 │ │ 2m12.4884505 
2m17.1114119 │ │ 2m12.4884548 Getting image                                                                                                ↵
2m17.1117228 │ │ 2m12.4884960 cr.selcloud.ru/example/tests-html:e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419     ↵
2m17.1117723 │ │ 2m12.4885478 info from the manifest cache...
2m17.1117998 │ │ 2m12.4926333 ┌ -- ManifestCache.GetImageInfo cr.selcloud.ru/example/tests-html cr.selcloud.ru/example/tests-html:e97cc9 ...
2m17.1121635 │ │ 2m12.4929193 └ -- ManifestCache.GetImageInfo cr.selcloud.ru/example/tests-html cr.selcloud.ru/example/te ... (0.00 seconds)
2m17.1122125 │ │ 2m12.4932098 
2m17.1122266 │ │ 2m12.4932152 Not found                                                                                                    ↵
2m17.1124720 │ │ 2m12.4933008 cr.selcloud.ru/example/tests-html:e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419     ↵
2m17.1125186 │ │ 2m12.4933479 image info in the manifest cache (CACHE MISS)
2m17.1127292 │ │ 2m12.4935112 Getting digest "e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa" uniqueID 1670937308419 stage info  ↵
2m17.1127786 │ │ 2m12.4935541 from cr.selcloud.ru/example/tests-html...
2m17.1130542 │ │ 2m12.4936961 -- RepoStagesStorage GetStageDescription html e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa       ↵
2m17.1131025 │ │ 2m12.4937467 1670937308419
2m17.1131186 │ │ 2m12.4939260 -- RepoStagesStorage stageImageName =                                                                        ↵
2m17.1133841 │ │ 2m12.4939748 "cr.selcloud.ru/example/tests-html:e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419"
2m17.1134307 │ │ 2m15.1480485 -- RepoStagesStorage.GetStageDescription check rejected image name: cr.selcloud.ru/example/tests-html:e97cc9 ↵
2m17.1136963 │ │ 2m15.1480932 6e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419-rejected
2m17.1137306 │ │ 2m17.1103948 Storing image                                                                                                ↵
2m17.1140278 │ │ 2m17.1104269 cr.selcloud.ru/example/tests-html:e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419     ↵
2m17.1140745 │ │ 2m17.1104644 info into manifest cache
2m17.1140945 │ │ 2m17.1104928 ┌ -- ManifestCache.StoreImageInfo cr.selcloud.ru/example/tests-html cr.selcloud.ru/example/tests-html:e97c ...
2m17.1142399 │ │ 2m17.1108265 └ -- ManifestCache.StoreImageInfo cr.selcloud.ru/example/tests-html cr.selcloud.ru/example/ ... (0.00 seconds)

Werf trying to get 6e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419-rejected and get 404:

2m15.1900938 │ │ 2022/12/13 13:22:50 --> GET https://cr.selcloud.ru/v2/example/tests-html/manifests/e97cc96e8e1094849110f1ef6160cff8a279c4 ↵
2m15.1901524 │ │ da5ea00d150f5405fa-1670937308419-rejected
2m15.1908100 │ │ 2022/12/13 13:22:50 GET                                                                                                   ↵
2m15.1908661 │ │ /v2/example/tests-html/manifests/e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419-rejected HTTP/1.1
2m15.1909630 │ │ Host: cr.selcloud.ru
2m15.1909845 │ │ User-Agent: go-containerregistry/v0.5.1
2m15.1915422 │ │ Accept: application/vnd.docker.distribution.manifest.v1+json,application/vnd.docker.distribution.manifest.v1+prettyjws,ap ↵
2m15.1916003 │ │ plication/vnd.docker.distribution.manifest.v2+json,application/vnd.oci.image.manifest.v1+json,application/vnd.docker.dist ↵
2m15.1916742 │ │ ribution.manifest.list.v2+json,application/vnd.oci.image.index.v1+json
2m15.1917091 │ │ Authorization: <redacted>
2m15.1917260 │ │ Accept-Encoding: gzip
2m15.1917422 │ │ 
2m15.1917482 │ │ 
2m17.1087403 │ │ 2022/12/13 13:22:52 <-- 404 https://cr.selcloud.ru/v2/example/tests-html/manifests/e97cc96e8e1094849110f1ef6160cff8a279c4 ↵
2m17.1087852 │ │ da5ea00d150f5405fa-1670937308419-rejected (1.916731161s)
2m17.1092056 │ │ 2022/12/13 13:22:52 HTTP/2.0 404 Not Found
2m17.1092230 │ │ Content-Type: application/json; charset=utf-8
2m17.1092398 │ │ Date: Tue, 13 Dec 2022 13:22:52 GMT
2m17.1092587 │ │ Docker-Distribution-Api-Version: registry/2.0
2m17.1092770 │ │ Server: envoy
2m17.1092846 │ │ Vary: Accept-Encoding
2m17.1093000 │ │ X-Content-Type-Options: nosniff
2m17.1095557 │ │ X-Request-Id: d7ab1be5-6e25-48f9-9d5d-43222d38148a
2m17.1095751 │ │ X-Selectel-Domain-Id: 0f174f91373d4f33988293b71671c57d
2m17.1095936 │ │ X-Selectel-Domain-Name: 225407
2m17.1096061 │ │ X-Selectel-Project-Id: 0eba4ef1449d46c6929daf22f7146f5f
2m17.1096276 │ │ X-Selectel-Project-Name: KlaN cloud
2m17.1098029 │ │ X-Selectel-Registry-Id: 51091ecd-72f6-45b1-98bd-4b14250245d2
2m17.1098250 │ │ X-Selectel-User-Id: 7f95e7b165ae4d7291f640ce7fb7ae35
2m17.1098445 │ │ X-Selectel-User-Name: reseller
2m17.1098573 │ │ 
2m17.1100112 │ │ {"errors":[{"code":"MANIFEST_UNKNOWN","message":"manifest                                                                 ↵
2m17.1100537 │ │ unknown","detail":{"Tag":"e97cc96e8e1094849110f1ef6160cff8a279c4da5ea00d150f5405fa-1670937308419-rejected"}}]}

Full log added.
out.txt

@alexey-igrychev
Copy link
Member

alexey-igrychev commented Dec 13, 2022

  • Added full log does not include werf log. Please, re-add it. Nonetheless, I do not see any problem with rejected images (a special tag that werf add in the case when the related image is broken), and cleanup should end without any error — it is a valid case.
  • We restructured documentation, and now you can find the relevant section here.
  • OFFTOP. What for do you need alternative Tags method implementation for the Selectel container registry? It seems you can fully remove it, and everything will work properly.
    func (r *selectel) Tags(ctx context.Context, reference string, _ ...Option) ([]string, error) {
    if r.hasExtraCredentials() {
    return r.tags(ctx, reference)
    }
    return r.api.tags(ctx, reference)
    }

@gyrter
Copy link
Contributor Author

gyrter commented Dec 14, 2022

Thank you @alexey-igrychev . I understand you position.

I will add fulllog and I will try to run without Tags method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants