fix(staged-dockerfile): correction for ENV and ARG instructions handling #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distorhead
force-pushed
the
staged-dockerfile-bug
branch
6 times, most recently
from
30c0300
to
99f329d
Compare
1. ARG should affect all RUN instruction digests which defined after ARG. 2. ARG could be used in the ENV instruction expansion. 3. ARG should not be expanded in the RUN instruction statically, instead expand it in runtime. Internally args should be passed as env vars when running RUN instructions. Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
… for unit test Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
distorhead
force-pushed
the
staged-dockerfile-bug
branch
from
99f329d
to
e0d430c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally args should be passed as env vars when running RUN instructions.
Signed-off-by: Timofey Kirillov timofey.kirillov@flant.com