Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/2.0.2/id check #40

Merged
merged 2 commits into from
May 24, 2024
Merged

Hotfix/2.0.2/id check #40

merged 2 commits into from
May 24, 2024

Conversation

tiller1010
Copy link
Member

@tiller1010 tiller1010 commented May 24, 2024 •
edited by aletail
Loading

https://werkbotstudios.teamwork.com/app/tasks/35150227

Summary

added check for docScores id in search results

Testing Steps

  • confirm there is a check for docScores ids

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"

@tiller1010 tiller1010 requested a review from aletail May 24, 2024 13:42
aletail
aletail approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@aletail aletail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@tiller1010 tiller1010 merged commit 313dfc1 into main May 24, 2024
3 checks passed
@github-actions github-actions bot deleted the hotfix/2.0.2/id-check branch May 24, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aletail aletail aletail approved these changes

Assignees
No one assigned
Labels
patch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiller1010 @aletail