Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function for countable offers #18

Closed
svenfnzd opened this issue Apr 14, 2021 · 0 comments · Fixed by #19
Closed

Add function for countable offers #18

svenfnzd opened this issue Apr 14, 2021 · 0 comments · Fixed by #19

Comments

@svenfnzd
Copy link
Contributor

Currently its not possible to add a condition, if offers are in the model.
@svenfnzd svenfnzd mentioned this issue Apr 14, 2021
Merged
DanielSiepmann pushed a commit that referenced this issue Apr 14, 2021
@svenfnzd @DanielSiepmann
Update offers model to add count
99b95ee 
Needed countable for checking if model contains content.

Relates: #18
DanielSiepmann pushed a commit that referenced this issue Apr 14, 2021
@svenfnzd @DanielSiepmann
Update openingHours model to add count
960d2de 
Needed countable for checking if model contains content.

Relates: #18
DanielSiepmann added a commit that referenced this issue Apr 14, 2021
@DanielSiepmann
Add tests for modified models
bbf7ada 
That's necessary as models grow.
Added features should be tested to not break with future changes.

The tests revealed an existing error in fallback which got fixed to make
new test pass.

Relates: #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated models to add count
1 participant
@svenfnzd