Placing a popover when it is too large for the available space on the screen #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a situation in my app where the popover to be opened is too large to fit to the screen with any arrow placement, and thus the popover won't open at all. This patch modifies the behaviour of WEPopover to make the popover smaller as necessary in such situations instead of not opening it at all.
Such a situation usually does not arise on the iPad but can happen frequently on the iPhone, so IMHO it's good to have some fallback mechanism in place for such situations even if it is not 100% compatible with the behaviour of the original UIPopoverController.
Also added the "properties" property to WEPopoverContainerView which seemed to be missing.